Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds RowDescription to the SimpleQueryMessage #1144

Merged
merged 6 commits into from
Jul 9, 2024
Merged

Adds RowDescription to the SimpleQueryMessage #1144

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6cd4652
Add RowDescription to SimpleQueryMessage
rigby-dane May 29, 2024
7afead9
Formatting updates
rigby-dane May 29, 2024
eec0602
Clippy compliance
rigby-dane May 29, 2024
bd6350c
Formatting
rigby-dane May 30, 2024
cfd9163
PR Fix: Only use single clone for RowDescription
rigby-dane Jul 7, 2024
2647024
PR Fix: Clone first then move
rigby-dane Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tokio-postgres/src/simple_query.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,9 @@ impl Stream for SimpleQueryStream {
.map_err(Error::parse)?
.into();

*this.columns = Some(columns.clone());
*this.columns = Some(columns);
Poll::Ready(Some(Ok(SimpleQueryMessage::RowDescription(
columns.clone(),
this.columns.as_ref().unwrap().clone(),
))))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this work?

                *this.columns = Some(columns.clone());
                Poll::Ready(Some(Ok(SimpleQueryMessage::RowDescription(
                    columns
                ))))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it does. I was clearly overthinking it. Thank you!

}
Message::DataRow(body) => {
Expand Down