Update Polars on Arrow2 and implement Polars on Arrow-rs #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update arrow-rs with .polars
Update polars
connectorx/Cargo.toml
Outdated
| @@ -71,11 +72,12 @@ iai = "0.1" | |||
| pprof = {version = "0.5", features = ["flamegraph"]} | |||
|
|
|||
| [features] | |||
| all = ["src_sqlite", "src_postgres", "src_mysql", "src_mssql", "src_oracle", "src_bigquery", "src_csv", "src_dummy", "src_trino", "dst_arrow", "dst_arrow2", "federation", "fed_exec"] | |||
| all = ["src_sqlite", "src_postgres", "src_mysql", "src_mssql", "src_oracle", "src_bigquery", "src_csv", "src_dummy", "src_trino", "dst_arrow", "dst_arrow2", "dst_arrow", "federation", "fed_exec", "dst_polars"] | |||
There was a problem hiding this comment.
a duplicate dst_arrow?
|
Thanks for drafting the design and submitting the PR! @EricFecteau I will take a deeper look at this by this weekend. |
|
@EricFecteau , the code looks good to me! In terms of resolving the array type issue, I left a comment in the discussion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to send the data to a modern version of Polars from both Arrow and Arrow2, through the FFI.
Some design decisions were made along the way (described here: #720), but more than willing to change those decisions! Had to disable two tests for Arrow2 as the data was not able to be moved between arrow2 and arrow_polars and these the functionality needed was also not implemented in Arrow.