Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use device local memory in the transient resource heap base #92

Closed
wants to merge 2 commits into from
Closed

Use device local memory in the transient resource heap base #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec69b86
Use device local memory in the transient resource heap base
aleino-nv Nov 1, 2024
7ee2a55
Free shader object layout cache and queue when destroying device
aleino-nv Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/transient-resource-heap-base.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ class TransientResourceHeapBaseImpl : public TransientResourceHeap

m_constantBufferPool.init(
device,
MemoryType::Upload,
MemoryType::DeviceLocal,
256,
BufferUsage::ConstantBuffer | BufferUsage::CopySource | BufferUsage::CopyDestination
);
Expand Down
6 changes: 5 additions & 1 deletion src/wgpu/wgpu-device.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,11 @@ Context::~Context()
}
}

DeviceImpl::~DeviceImpl() {}
DeviceImpl::~DeviceImpl()
{
m_shaderObjectLayoutCache = decltype(m_shaderObjectLayoutCache)();
m_queue.setNull();
}

Result DeviceImpl::getNativeDeviceHandles(DeviceNativeHandles* outHandles)
{
Expand Down