Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bgra8 format #6163

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

fairywreath
Copy link
Contributor

Closes #5469.

Adds bgra8 format. This is mainly for WGSL targets where bgra8unorm is supported. This format is implicitly translated to unknown for GLSL and SPIRV targets. This change does not affect HLSL and Metal targets as they (currently) do not explicitly output image formats. This change also adds warning where an image format is explicitly stated, but the backend does not explicitly support the format, although the format itself may be implicitly supported by the unknown format.

@fairywreath fairywreath requested a review from a team as a code owner January 23, 2025 07:33
@fairywreath fairywreath changed the title Add bgra8 format. Add bgra8 format Jan 23, 2025
Copy link
Collaborator

@csyonghe csyonghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@csyonghe csyonghe added the pr: non-breaking PRs without breaking changes label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: non-breaking PRs without breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

slang doesn't support bgra8 format texture.
2 participants