Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt: Improve user experience on Steam Deck and window managers #2103

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

tomboylover93
Copy link
Contributor

This aims to fix issues with the Qt interface on (mostly Linux) desktops that hide the app's titlebar and buttons, such as the Steam Deck's Gaming Mode, which uses Gamescope (see #2086), and the aforementioned window managers. They range from minor quirks to issues that make it outright impossible to perform some actions solely using the GUI, and some examples are:

  • the lack of a "Close" button for the Cheats/Patches window, and
  • the Settings window resizing itself when hovering over something whose description text occupies more screen real estate than 70px:
Screencast_20250108_134905.mp4

The latter causes weird behavior outside of those desktop interfaces, as when maximizing the Settings window on any desktop environment the text box resizing mechanism does not respect the actual window size, which leads to this:

image

I'll leave it as a draft for now because I want more input from people using said desktops and other operating systems than Linux, since there might be something I missed or that needs to be changed.

…w close the window when clicked

This addresses one of the issues with using shadPS4 on a Steam Deck, or any desktop and/or interface that hides the titlebar, such as window managers
This fixes another issue with shadPS4 on desktops and interfaces that hide the app's titlebar
This fixes the window resizing with long descriptions for options, which causes problems with Gamescope and as a result Steam Deck, as well as when maximizing the Settings window on normal desktops
@DanielSvoboda
Copy link
Contributor

DanielSvoboda commented Jan 9, 2025

Changing bottomMargin from 11 to 190 in UpdateLayout makes it not so stretched

<number>11</number>

image

@GHU7924
Copy link

GHU7924 commented Jan 9, 2025

Now the window does not change size and works properly.
The Patches window closes after saving.
It has clearly improved, but there is still such a moment (it's not critical, but it is):
Cheats

@tomboylover93 To test and get an approximate experience of using the emulator on Steam Deck,
you should change the resolution for the virtual machine.
The Steam Deck has a 16:10 aspect ratio and a resolution of 1280x800.

@tomboylover93
Copy link
Contributor Author

I don't think I could change much about the drop-down menu resizing the window, that's just how Gamescope is. Though I could make it open upwards instead of downwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants