Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt: Open shadPS4 Folder #2107

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Qt: Open shadPS4 Folder #2107

wants to merge 2 commits into from

Conversation

Xphalnos
Copy link
Collaborator

@Xphalnos Xphalnos commented Jan 9, 2025

The idea comes from yuzu and the code is extremely inspired by #2102. So thanks @DanielSvoboda!

Before:
img

After:
img

@GHU7924
Copy link

GHU7924 commented Jan 9, 2025

I think it's enough just to add one more point here.
1

If we talk about the menu you specified, then in order not to inflate it, you can make a general "Open..." in which there will be a choice of "Open/Add Elf Folder" and "Open shadPS4 Folder".

I do not know how important access to the entire emulator folder is, but most often we access the User folder, so we have access to all the saves, logs, and system modules. I think it's worth adding quick access to the system modules.

@squidbus
Copy link
Collaborator

squidbus commented Jan 9, 2025

I'm in favor of having the open user folder button in the main menu as it is now in this PR. Easy to find and access for people who need to go to their user folder, especially on Linux/macOS where it may be somewhere else in a standard user path like .local/share or Library/Application Support.

I don't think it would make sense to put this in the game right-click menu as it is not per-game, in fact I don't know why there's a log folder option there in the first place for the same reason.

@DanielSvoboda
Copy link
Contributor

Maybe this order would be better:
install
Boot
Recent
Open/add
Open shadps4
Exit

@DanielSvoboda
Copy link
Contributor

I'm in favor of having the open user folder button in the main menu as it is now in this PR. Easy to find and access for people who need to go to their user folder, especially on Linux/macOS where it may be somewhere else in a standard user path like .local/share or Library/Application Support.

I don't think it would make sense to put this in the game right-click menu as it is not per-game, in fact I don't know why there's a log folder option there in the first place for the same reason.

I placed the button to open the 'log' folder on the right button so that it is easily accessible, without having to open menus, although it is not something individual to each game.

@Foul-Tarnished
Copy link

I'm in favor of having the open user folder button in the main menu as it is now in this PR. Easy to find and access for people who need to go to their user folder, especially on Linux/macOS where it may be somewhere else in a standard user path like .local/share or Library/Application Support.
I don't think it would make sense to put this in the game right-click menu as it is not per-game, in fact I don't know why there's a log folder option there in the first place for the same reason.

I placed the button to open the 'log' folder on the right button so that it is easily accessible, without having to open menus, although it is not something individual to each game.

Would make more sense to be in the file menu instead, and as easily accessible

@GHU7924
Copy link

GHU7924 commented Jan 10, 2025

I don't think it would make sense to put this in the game right-click menu as it is not per-game, in fact I don't know why there's a log folder option there in the first place for the same reason.

I think that since we have a common log for all games, it can be removed from the context menu altogether.

I'm in favor of having the open user folder button in the main menu as it is now in this PR. Easy to find and access for people who need to go to their user folder, especially on Linux/macOS where it may be somewhere else in a standard user path like .local/share or Library/Application Support.

I forgot that Linux has such a folder separation. Then you should add another folder that leads to User.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants