Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: receipt details to ReceiptInterface #295

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alikhani97
Copy link

We have this issue where we don't have access to the receipt details right after verifying payment!

Motivation for the Change

  1. Standardization: These additions align the ReceiptInterface with the Receipt implementation, ensuring all details are accessible through the defined interface methods.
  2. Flexibility: Provides a built-in way for users to retrieve metadata stored in detail() without requiring dedicated getters for each specific key.
  3. Code Consistency: Brings parity between the concrete Receipt class (which uses HasDetail) and its contract, making it clear that details and metadata are part of the core functionality.
  4. Improved Usability: Users can now access and manipulate transaction metadata more easily through methods that adhere to the interface, improving the developer experience.

@alikhani97 alikhani97 force-pushed the receipt-details-to-receipt-interface branch from 8f391dd to 1ad7a3e Compare January 7, 2025 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant