Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: complete github action [SHFT-1] #7

Merged
merged 18 commits into from
Oct 11, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 0 additions & 83 deletions .github/linters/.eslintrc.yml

This file was deleted.

7 changes: 0 additions & 7 deletions .github/linters/.markdown-lint.yml

This file was deleted.

10 changes: 0 additions & 10 deletions .github/linters/.yaml-lint.yml

This file was deleted.

9 changes: 0 additions & 9 deletions .github/linters/tsconfig.json

This file was deleted.

29 changes: 29 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
# Checklist

<!-- checklist-start -->

- [ ] I've reviewed my code. (\*)
- [ ] Does this task have an ID?
- [ ] Should this task be tested by testers? (\*)
- [ ] Is there a need to add new translations
- [ ] I've placed all translations in the appropriate JSON files. (\*)
- [ ] I've verified that the translations work as expected in different languages. (\*)
- [ ] Are there any UI changes?
- [ ] Screenshots or screen recordings of the changes have been attached to the PR. (\*)
- [ ] No unnecessary console logs or commented out code remains. (\*)
- [ ] I didn't hard-code any sensitive information.(\*)
- [ ] I've tested browser compatibility. (e.g. Chrome, Safari, Mozilla, Opera) (\*)
- [ ] All new and existing tests have passed. (\*)
- [ ] I've checked for potential performance issues. (e.g. slow component mounting, too many HTTP requests, unnecessary re-renders) (\*)
- [ ] I've addressed accessibility concerns. (\*)
- [ ] I've added a new dependency.
- [ ] I've checked that all newly added dependencies are secure and up-to-date. (\*)
- [ ] The PR contains only changes related to the task at hand. If there are any changes outside of the task, I've mentioned them in the description. (\*)

<!-- checklist-end -->

---

**Related Issue Link(s):** ...

**Description:** ...
46 changes: 29 additions & 17 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,30 @@ name: Continuous Integration

on:
pull_request:
push:
branches:
- main
- 'releases/*'
types:
[
assigned,
unassigned,
labeled,
unlabeled,
opened,
edited,
closed,
reopened,
synchronize,
converted_to_draft,
ready_for_review,
locked,
unlocked,
review_requested,
review_request_removed,
auto_merge_enabled,
auto_merge_disabled
]

concurrency:
group: ${{ github.ref }}
cancel-in-progress: true

jobs:
test-typescript:
Expand All @@ -32,14 +52,6 @@ jobs:
id: npm-format-check
run: npm run format:check

- name: Lint
id: npm-lint
run: npm run lint

- name: Test
id: npm-ci-test
run: npm run ci-test

test-action:
name: GitHub Actions Test
runs-on: ubuntu-latest
Expand All @@ -53,8 +65,8 @@ jobs:
id: test-action
uses: ./
with:
milliseconds: 1000

- name: Print Output
id: output
run: echo "${{ steps.test-action.outputs.time }}"
reviewerRequired: true
assigneeRequired: true
checklistRequired: true
semanticTitleRequired: true
repoToken: ${{ secrets.SECRET_TOKEN }}
44 changes: 0 additions & 44 deletions .github/workflows/linter.yml

This file was deleted.

29 changes: 22 additions & 7 deletions action.yml
Original file line number Diff line number Diff line change
@@ -1,14 +1,29 @@
name: 'The name of your action here'
description: 'Provide a description here'
author: 'Your name or organization here'
name: 'SHFT PullMate'
description: 'A GitHub Action that checks if a pull request meets the requirements of the SHFT workflow'
author: 'SHFT'

# Define your inputs here.
inputs:
milliseconds:
description: 'Your input description here'
reviewerRequired:
description: 'Whether a reviewer is required or not'
required: true
default: '1000'

default: 'true'
assigneeRequired:
description: 'Whether an asignee is required or not'
required: true
default: 'true'
checklistRequired:
description: 'Whether a checklist is required or not'
required: true
default: 'true'
semanticTitleRequired:
description: 'Whether a semantic title is required or not'
required: true
default: 'true'
repoToken:
description: 'The repository token'
required: true

# Define your outputs here.
outputs:
time:
Expand Down
Loading
Loading