Add option to save off .pose files for each segment #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmitMY
requested changes
Nov 27, 2024
cleong110
commented
Dec 4, 2024
…ines/whitespace, and opening with a specific encoding
|
All right, I think we're about good, though there's probably more stylistic improvements to be made. ChatGPT has these suggestions: https://chatgpt.com/share/675065df-c64c-800e-b171-5486a47eb024 |
AmitMY
requested changes
Dec 4, 2024
sign_language_segmentation/bin.py
Outdated
| for segment in segments: | ||
| eaf.add_annotation(tier_id, int(segment["start"] / fps * 1000), int(segment["end"] / fps * 1000)) | ||
| # convert frame numbers to millisecond timestamps, for Elan | ||
| start_frame_time = int(segment["start"] / fps * frames_per_millisecond) |
There was a problem hiding this comment.
this implementation is now wrong.
Was:
segment["start"] / fps * 1000Now:
segment["start"] / fps * fps * 1000There was a problem hiding this comment.
I suggest
start_time = int(segment["start"] / fps * 1000)There was a problem hiding this comment.
Ah, it was wrong indeed! Fixed now
AmitMY
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.