fsw similarity metrics #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmitMY
requested changes
Jan 5, 2024
AmitMY
requested changes
Jan 9, 2024
AmitMY
requested changes
Jan 10, 2024
| self.weight["positional"] * dis.euclidean(hyp["position"], ref["position"])) | ||
| hyp_class = next((i for i, r in enumerate(self.symbol_classes.values()) if shape1 in r), None) | ||
| ref_class = next((i for i, r in enumerate(self.symbol_classes.values()) if shape2 in r), None) | ||
| distance = distance + abs(ref_class - hyp_class) * self.weight["class_penalty"] |
There was a problem hiding this comment.
i feel like this might be too lenient - in my opinion, same class = 1, different class = 0
AmitMY
requested changes
Jan 10, 2024
AmitMY
requested changes
Jan 11, 2024
| @@ -14,45 +14,45 @@ def __init__(self): | |||
| super().__init__("SymbolsDistances") | |||
| self.symbol_classes = { | |||
| 'hand_shapes': range(0x100, 0x205), | |||
| 'contact_symbols': range(0x205, 0x221), | |||
| 'movement_paths': range(0x221, 0x2FF), | |||
There was a problem hiding this comment.
why did you remove all of them? even if removed, maybe leave them as commented out.
| hyp_veq = tuple(val * weight for val, weight in zip(hyp_veq, [self.weight["shape"], self.weight["angle"], | ||
| self.weight["facing"], self.weight["parallel"], | ||
| self.weight["positional"]])) | ||
| ref_veq = tuple(val * weight for val, weight in zip(ref_veq, [self.weight["shape"], self.weight["angle"], |
There was a problem hiding this comment.
this could also be a function btw weigh_vector
AmitMY
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1