Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joeys2t adaptation #2

Merged
merged 30 commits into from
Jan 10, 2024
Merged

Joeys2t adaptation #2

merged 30 commits into from
Jan 10, 2024

Conversation

RotemZilberman
Copy link
Collaborator

No description provided.

Copy link
Contributor

@AmitMY AmitMY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for creating a PR.

a few things to get started:

  1. all code in a python project must be under a "package". in this case, the package is signwriting_transcription and so code should be under there (create as many subdirectories as you wish). Also, to allow for more approaches in the future, it might be wise to put the code under signwriting_transcription/pose_to_text for example (and then another could be vq_to_text or video_to_text etc)
  2. It is important to create a README to explain your approach, or at least usage of it. If you want your ipynb file to be the instructions for now that is fine, but then use %%capture to capture unnecessary outputs like pip install or unzip etc
  3. I see you did not modify the pyproject.toml, but you should specify your dependencies (at least joeynmt)

joeyP2S_running.ipynb Outdated Show resolved Hide resolved
data_preparation/poseData_utils.py Outdated Show resolved Hide resolved
data_preparation/swu_representation.py Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this config.py should be config.yaml since it only writes a yaml file.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is an easier way to use the config in the colab, is it ok?

data_preparation/data_preprocessing.py Outdated Show resolved Hide resolved
data_preparation/datasets_pose.py Outdated Show resolved Hide resolved
data_preparation/download_script.py Outdated Show resolved Hide resolved
data_preparation/download_script.py Outdated Show resolved Hide resolved
training/swu_tokenizer.py Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of this file, you can implement sign-language-processing/signwriting-evaluation#1
and then use it like from signwriting_evaluation.metrics.similarity import SignWritingSimilarityMetric for example

@AmitMY AmitMY merged commit f492c0b into main Jan 10, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants