Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant toggle Approve All members callback #13886

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Sagar0-0
Copy link
Contributor

@Sagar0-0 Sagar0-0 commented Jan 8, 2025

First time contributor checklist

Contributor checklist

  • Device Realme GT NET 3T, Android 14
  • Device Infinix hot 20 Pro, Android 14
  • Virtual device Pixel 8 Pro, Android 14
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

Simply remove the redundant callback, as it is already present in the ToggleRow.

One suggestion/feedback,
For the new Loading state in the toggle row, it is a better user interface experience to show the CircularProgressIndicator in the Switch composable's thumbContent param, this gives a more consistent user experience and won't feel ugly when switching to ProgressIndicator and switching bar to Switch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant