Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TopBar visibility reset after onResume in MultiSelect #13901

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Sagar0-0
Copy link
Contributor

First time contributor checklist

Contributor checklist

  • Device Realme GT Neo 3t, Android 14
  • Device Infinix Hot 20 Pro, Android 14
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

This issue was found for the Calls Log Screen but later I saw the same problem with the Chats List screen too, so a better place is the MainActivityListHostFragment to handle this issue. It has been found that

// onResume - MainActivityListHostFragment
    requireView()
      .findViewById<View>(R.id.fragment_container)
      .findNavController()
      .addOnDestinationChangedListener(destinationChangedListener)

is causing the toolbar state to reset. But adding a condition on this important operation is not a good idea hence the best solution is to hide the toolbar again after onResume.

Screenshots:

Before:

document_6057404072191892035.mp4

After:

document_6057404072191892034.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant