Bump Bitfield
smallvec to 128 to avoid heap allocations
#38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increases the size of the
Bitfield
on the stack to 128 bytes. If thesmallvec
exceeds this then it will allocate to the heap.This has the effect of ensuring that the
Attestation
bitfield can live on the stack for all networks with up to ~2M validators.Allocating the
Attestation
to the heap is slow and increase memory fragmentation. This affects attestation deserialisation (happens very frequently) and block deserialisation (happens less frequently, but is latency critical).Why 80 bytes?
The number of validators supported by a given bitfield size is
N * 32 slots * 64 committees * 8 bits
.At the time of writing, mainnet has ~1.1M active validators and Holesky has ~1.76M.
128 is a nice round multiple of 8 that fits Holesky without putting too much on the stack.
Notes
This PR originally appeared at sigp/ssz_types#35