Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve our composer commands in Makefile #223

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Improve our composer commands in Makefile #223

merged 2 commits into from
Nov 13, 2024

Conversation

forevermatt
Copy link
Contributor

WAITING FOR

Changed (non-breaking)

  • Have make composer and make composerupdate use the same container

Fixed

  • Use our improved approach for a developer-friendly list of dependencies
    • Note:
      • This replaces our direct-dependencies.txt file (all direct dependencies) with a dependencies.json file (all non-dev dependencies, even indirect/sub-dependencies).
      • This PR does not yet actually update any dependencies, to make that future PR's diff easier to review.

@forevermatt forevermatt requested review from a team, briskt, mtompset, jason-jackson and hobbitronics and removed request for a team November 13, 2024 16:04
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@forevermatt forevermatt mentioned this pull request Nov 13, 2024
Merged
Base automatically changed from feature/use-correct-platform-for-dev-containers to develop November 13, 2024 16:34
@forevermatt forevermatt merged commit 01f22b4 into develop Nov 13, 2024
2 checks passed
@forevermatt forevermatt deleted the feature/improve-friendly-list-of-dependencies branch November 13, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jason-jackson jason-jackson jason-jackson approved these changes

@briskt briskt Awaiting requested review from briskt briskt was automatically assigned from silinternational/php-devs

@mtompset mtompset Awaiting requested review from mtompset mtompset was automatically assigned from silinternational/php-devs

@hobbitronics hobbitronics Awaiting requested review from hobbitronics hobbitronics was automatically assigned from silinternational/php-devs

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@forevermatt @jason-jackson