Rename function for clarity and remove some debugging echos

silinternational · Jan 22, 2025 · 8160b68 · 8160b68
1 parent 0b57ad9
commit 8160b68
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/SilMock/Google/Service/Groupssettings/Resource/Groups.php b/SilMock/Google/Service/Groupssettings/Resource/Groups.php
@@ -32,11 +32,9 @@ public function delete(string $groupKey)
         }
     }
 
-    protected function doesGroupExist(string $groupKey): bool
+    protected function doGroupsSettingsExist(string $groupKey): bool
     {
-        echo "PASSED GROUPKEY: " . $groupKey . "\n";
         $groupsSettings = $this->get($groupKey);
-        echo "RESULTS: " . json_encode($groupsSettings, JSON_PRETTY_PRINT) . "\n";
         return ($groupsSettings !== null);
     }
 
@@ -67,7 +65,7 @@ public function get(string $groupKey): ?GoogleGroupsSettings_Groups
      */
     public function insert(GoogleGroupsSettings_Groups $postBody, $optParams = [])
     {
-        if (! $this->doesGroupExist($postBody->getEmail())) {
+        if (! $this->doGroupsSettingsExist($postBody->getEmail())) {
             $id = str_replace(array(' ', '.'), '', microtime());
             $postBody['id'] = $postBody['id'] ?? $id;
             $dataAsJson = json_encode(get_object_vars($postBody));
@@ -78,8 +76,8 @@ public function insert(GoogleGroupsSettings_Groups $postBody, $optParams = [])
 
     public function update(string $groupKey, GoogleGroupsSettings_Groups $postBody, $optParams = []): GoogleGroupsSettings_Groups
     {
-        if (! $this->doesGroupExist($postBody->getEmail())) {
-            throw new Exception("Group '{$groupKey}' does not exist.");
+        if (! $this->doGroupsSettingsExist($postBody->getEmail())) {
+            throw new Exception("Group Settings for '{$groupKey}' does not exist.");
         }
         $groupsSettings = $this->get($groupKey);