Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add groupssettings api #123

Merged
merged 3 commits into from
Jan 22, 2025
Merged

Add groupssettings api #123

merged 3 commits into from
Jan 22, 2025

Conversation

mtompset
Copy link
Contributor

Add

  • Groupssettings API
    • get method
    • update method
  • Tests for the two Groupssettings API methods

Change

  • Groups to create/delete group settings when groups are created/deleted.

@mtompset mtompset requested a review from a team January 22, 2025 16:10
@mtompset mtompset self-assigned this Jan 22, 2025
@mtompset mtompset requested review from briskt, forevermatt, jason-jackson and hobbitronics and removed request for a team January 22, 2025 16:10
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mtompset mtompset merged commit 0b57ad9 into develop Jan 22, 2025
3 checks passed
@mtompset mtompset deleted the feature/add-groupssettings-api branch January 22, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@forevermatt forevermatt forevermatt approved these changes

@briskt briskt Awaiting requested review from briskt briskt was automatically assigned from silinternational/php-devs

@jason-jackson jason-jackson Awaiting requested review from jason-jackson jason-jackson was automatically assigned from silinternational/php-devs

@hobbitronics hobbitronics Awaiting requested review from hobbitronics hobbitronics was automatically assigned from silinternational/php-devs

Assignees

@mtompset mtompset

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtompset @forevermatt