Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pushing Docker Image to GHCR.io #172

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Pushing Docker Image to GHCR.io #172

merged 3 commits into from
Oct 21, 2024

Conversation

Praveenraj-K
Copy link
Contributor

Added
Added step to push the docker image to Github Container Registry

@Praveenraj-K Praveenraj-K requested a review from a team October 21, 2024 09:29
briskt
briskt approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@briskt briskt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just keep an eye on indentation. If you need a plugin to do the work for you, that would be fine. But VSCode out of the box should handle indentation. When you hit tab, does it not add two spaces in a file that uses 2-space indentation?

.github/workflows/test-and-publish.yml Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Praveenraj-K Praveenraj-K merged commit 915fb62 into main Oct 21, 2024
3 checks passed
@Praveenraj-K Praveenraj-K deleted the feature-image-ghcr.io branch October 21, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briskt briskt briskt approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Praveenraj-K @briskt