Typescript #170
Open
Typescript #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@simonh1000 took another fresh pass on this with a priority to minimizing any changes to the library. Instead, I just focused on converting to TS. LMK what you think |
As long as there is a test case for both and the result is the same it should be fine to use the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds typescript and converts all
jsfiles totsfiles.This adds a build step, see
package.jsonfor details.Verification
tscbuild passed and tests passednpm linkinto a sample app to verify functionalityFuture Work
ascasting. This was mostly done becausethis.ftpcould either bePromiseFtporPromiseSftp, and those types do not play well with each other. The code is functionally the same, but the typescript could be cleaned up in this area.