Fix documentation, make ISO date format standard in some places #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonmichael
reviewed
Feb 8, 2020
| @@ -132,7 +132,7 @@ Render a journal transaction as text in the style of Ledger's print command. | |||
| Ledger 2.x's standard format looks like this: | |||
|
|
|||
| @ | |||
| yyyy/mm/dd[ *][ CODE] description......... [ ; comment...............] | |||
| yyyy-mm-dd[ *][ CODE] description......... [ ; comment...............] | |||
There was a problem hiding this comment.
Not correct I think, both Ledger 2 and 3 print dates with slashes.
There was a problem hiding this comment.
Oh, right. But this is the documentation for the showTransaction function, so we also have to fix the sentence above my change.
There was a problem hiding this comment.
I changed the above part of comment.
| @@ -14,7 +14,7 @@ From timeclock.el 2.6: | |||
| A timeclock contains data in the form of a single entry per line. | |||
| Each entry has the form: | |||
|
|
|||
| CODE YYYY/MM/DD HH:MM:SS [COMMENT] | |||
| CODE YYYY-MM-DD HH:MM:SS [COMMENT] | |||
There was a problem hiding this comment.
https://www.ledger-cli.org/3.0/doc/ledger3.html#Time-Keeping says it contains slashes, but Ledger reads slash or dash or dot, like hledger. Emacs' timeclock.el requires slashes. I can tweak this comment later maybe.
There was a problem hiding this comment.
I reverted this change for now, to keep the compatibility to the original doc and Emacs.
schoettl
force-pushed
the
fix/iso-date-format
branch
from
ff0d276 to
d27f521
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #933