Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An implementation for
encoding
in rules file:The cases are:
-f *.rules
-f *.csv
-f *.csv --rules *.rules
The second and third case are effectively the same. The problem is that for them we call a
Reader
srReadFn
value taking the contents rather then the filepath / handle.So we either would have to change
Reader
to take aFilePath
instead ofText
, which would break how we do Tests,or we add an extra field
rGetContents :: FilePath -> IO Text
.I would rather get some feedback on this before I implement a potentially bigger change.
If implemented this PR should: