Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli, web, ui: Replace withJournalDo* variants #979

Merged
merged 1 commit into from
Mar 1, 2019

Conversation

zarybnicky
Copy link
Contributor

This finally removes the duplication between hledger-cli's, hledger-ui's and
hledger-web's entrypoints. I'd wanted to do this a long time ago, but only now
was I annoyed enough by the XXX's around those places to actually do it :)

On another note, this PR conflicts with my other one (#978). I didn't want to
create a PR against another PR, so whichever one you get around to merging
first, I'll just need to rebase the other one (for the three lines of worth of
conflicts, oh well).

There is just one thing I'm not sure about. The original hledger-ui's entrypoint
did some changes to CLIOpts that I've pulled out so that they are now sent to
both withJournalDo and to runBrickUI, which wasn't the case previously as
runBrickUi used the unchanged UIOpts. The two options affected are auto_
and forecast_. AFAICT, these pertain just to reading the journal, but the
change might affect a potential reloadJournalIfChanged, so I'm mentioning it
here...

@simonmichael simonmichael added web The hledger-web tool. cli Command line parsing, options, arguments and suchlike. ui The hledger-ui tool. labels Mar 1, 2019
@simonmichael
Copy link
Owner

Great, thanks! If you have any time to test that hledger-ui --watch preserves --auto, --forecast, and any startup flags like -R, that would be helpful. I hope to do a release today.

@simonmichael simonmichael merged commit 6becbc7 into simonmichael:master Mar 1, 2019
@simonmichael
Copy link
Owner

PS I did that testing, it seems fine.

@zarybnicky zarybnicky deleted the unify-withledgerdo branch March 2, 2019 21:13
@zarybnicky
Copy link
Contributor Author

Thanks, I didn't manage to find the time yesterday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Command line parsing, options, arguments and suchlike. ui The hledger-ui tool. web The hledger-web tool.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants