cli, web, ui: Replace withJournalDo* variants #979
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finally removes the duplication between hledger-cli's, hledger-ui's and
hledger-web's entrypoints. I'd wanted to do this a long time ago, but only now
was I annoyed enough by the XXX's around those places to actually do it :)
On another note, this PR conflicts with my other one (#978). I didn't want to
create a PR against another PR, so whichever one you get around to merging
first, I'll just need to rebase the other one (for the three lines of worth of
conflicts, oh well).
There is just one thing I'm not sure about. The original hledger-ui's entrypoint
did some changes to
CLIOpts
that I've pulled out so that they are now sent toboth
withJournalDo
and torunBrickUI
, which wasn't the case previously asrunBrickUi
used the unchangedUIOpts
. The two options affected areauto_
and
forecast_
. AFAICT, these pertain just to reading the journal, but thechange might affect a potential
reloadJournalIfChanged
, so I'm mentioning ithere...