Trunk: use native dart-sass (ipetkov#360)

Replace the javascript version of dart-sass with a native binary version. Should improve built times and reduce disk usage. --------- Co-authored-by: Ivan Petkov <[email protected]>
simonzkl · Aug 11, 2023 · 1b8653a · 1b8653a
1 parent ff2e879
commit 1b8653a
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## Unreleased
 
+### Changed
+* `buildTrunkPackage` will now use `dart-sass` instead of `nodePackages.sass`
+
 ## [0.13.0] - 2023-08-07
 
 ### Added

diff --git a/docs/API.md b/docs/API.md
@@ -282,7 +282,7 @@ environment variables during the build, you can bring them back via
 #### Native build dependencies and included hooks
 The following hooks are automatically added as native build inputs:
 * `binaryen`
-* `nodePackages.sass`
+* `dart-sass`
 * `trunk`
 * `wasm-bindgen-cli`
 

diff --git a/lib/buildTrunkPackage.nix b/lib/buildTrunkPackage.nix
@@ -2,7 +2,7 @@
 , buildDepsOnly
 , crateNameFromCargoToml
 , mkCargoDerivation
-, nodePackages
+, dart-sass
 , removeReferencesToVendoredSourcesHook
 , trunk
 , vendorCargoDeps
@@ -72,9 +72,7 @@ mkCargoDerivation (args // {
 
   nativeBuildInputs = (args.nativeBuildInputs or [ ]) ++ [
     binaryen
-    # dart-sass compiled to javascript
-    # TODO: replace with a native version when it comes to nixpkgs
-    nodePackages.sass
+    dart-sass
     trunk
     wasm-bindgen-cli
     # Store references are certainly false positives