This repository has been archived by the owner on Jan 25, 2023. It is now read-only.
Add support for legacy webOS Mobile devices #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requesting a review of this PR :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for legacy webOS mobile OS detection, for devices like the Palm Pre and the HP Touchpad.
Similar to Android, the OS is Linux based, so the detection must precede the Linux function. There were two major variants of legacy webOS, one for phones, one for tablets and both are detected. (an unreleased prototype device may have a third variant, but they are so rare I was unable to acquire one to test.) A unit test was added for the tablet variant, which is the most common device still online, and all tests pass.
More about legacy webOS here: www.webosarchive.com
Modern webOS is owned by LG, is used for their Smart TVS, and the built-in browser has a different user agent string. I'll work on adding support for that in a future PR.