Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly adding unit to number [tentcss/src/02_tools/_scaling.scss] #28

Open
dimbslmh opened this issue Mar 5, 2018 · 1 comment
Open
Assignees

Comments

@dimbslmh
Copy link

dimbslmh commented Mar 5, 2018

Currently rem and em functions are returning a string, because the unit is incorrectly appended.
See: https://css-tricks.com/snippets/sass/correctly-adding-unit-number/

$return: append($return, ($val / $root + rem));
} @else {
$return: append($return, ($val * $root + px));

 	$return: append($return, ($val / $root + rem)); 
 } @else { 
 	$return: append($return, ($val * $root + px)); 

$return: append($return, ($val / $root + em));
} @else {
$return: append($return, ($val * $root + px));

 	$return: append($return, ($val / $root + em)); 
 } @else { 
 	$return: append($return, ($val * $root + px)); 
@ulinaaron
Copy link
Collaborator

It looks like newer versions of Node Sass are breaking this. I'll be looking into doing a refactor for the current version of Tent to address this.

@ulinaaron ulinaaron self-assigned this Apr 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants