Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task: Disable Board until players are selected #81

Merged
merged 2 commits into from
Oct 6, 2024

Conversation

MullerTheScientist
Copy link
Contributor

@MullerTheScientist MullerTheScientist commented Sep 30, 2024

Description

This implementation disables the board until the number of players has been selected

Related Issue(s)

Closes #71

Checklist:

  • Read the contributing docs (if this is your first contribution)
  • Verified this is not a duplicate of any existing pull request
  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Linked the issues which this PR resolves
  • Documented the changes in code (API docs will be generated automatically)

Test

I performed a manual test to ensure the implementation was correct

@0xibs 0xibs requested review from vibenedict and 0xibs September 30, 2024 18:31
Copy link
Collaborator

@0xibs 0xibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

  • Please fix error causing client CI to fail
  • Also your pull request description should follow the structure of the pull request template

@MullerTheScientist
Copy link
Contributor Author

Requested Changes Have been Implemented

@0xibs 0xibs merged commit 116aee8 into sivicstudio:dev Oct 6, 2024
3 checks passed
Copy link
Collaborator

@0xibs 0xibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable board until number of players have been selected
2 participants