Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] interface MapieRegressor from mapie #136

Merged
merged 25 commits into from
Oct 28, 2023
Merged

[ENH] interface MapieRegressor from mapie #136

merged 25 commits into from
Oct 28, 2023

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Oct 28, 2023

Fixes #134.

Interfaces mapie.regression.MapieRegressor, and introduces mapie as an optional soft dependency.

Proof-of-concept for third party package interfaces, similar to sktime third party interface handling

Depends on:

@fkiraly fkiraly added enhancement module:regression probabilistic regression module interfacing algorithms Interfacing existing algorithms/estimators from third party packages labels Oct 28, 2023
@fkiraly
Copy link
Collaborator Author

fkiraly commented Oct 28, 2023

Failures in run-tests-no-extras are benign, due to test framework not excluding estimators which require extras. This can be solved by copying the same logic from sktime (should probably be in skbase at some point).

@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2023

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (a560ec7) 71.92% compared to head (a11f6d1) 63.86%.
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
- Coverage   71.92%   63.86%   -8.07%     
==========================================
  Files          98      100       +2     
  Lines        5290     5369      +79     
  Branches      978      990      +12     
==========================================
- Hits         3805     3429     -376     
- Misses       1214     1668     +454     
- Partials      271      272       +1     
Files Coverage Δ
skpro/distributions/tests/test_all_distrs.py 27.46% <100.00%> (-65.50%) ⬇️
skpro/regression/tests/test_all_regressors.py 100.00% <100.00%> (ø)
skpro/tests/test_all_estimators.py 85.00% <100.00%> (+0.70%) ⬆️
skpro/utils/validation/_dependencies.py 37.50% <0.00%> (+6.73%) ⬆️
skpro/tests/test_switch.py 70.83% <70.83%> (ø)
skpro/regression/mapie.py 73.58% <73.58%> (ø)

... and 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fkiraly fkiraly mentioned this pull request Oct 28, 2023
@fkiraly fkiraly merged commit 9cf4b0e into main Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement interfacing algorithms Interfacing existing algorithms/estimators from third party packages module:regression probabilistic regression module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] MAPIE interface
2 participants