feat: Client-side faction sync #2052
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now GetFactions are skipped because VarValue array is missing
as GetFaction is not supported in vanilla or SKSE
…o factions-sync
Pospelove
requested changes
Jun 25, 2024
Pospelove
reviewed
Jul 2, 2024
skymp5-client/src/view/formView.ts
Outdated
| @@ -285,6 +285,11 @@ export class FormView implements View<FormModel> { | |||
| if (model.appearance && model.appearance.name) { | |||
| refr?.setDisplayName("" + model.appearance.name, true); | |||
| } | |||
| if (model.factions !== undefined && model.factions.length > 0) { | |||
| for (let i = 0; i < model.factions.length; i++) { | |||
| (Actor.from(refr) as any).addToFaction(Faction.from(Game.getFormEx(model.factions[i].formDesc))); | |||
There was a problem hiding this comment.
Actor.from is expensive. should be put out of loop. also it can return null which should be checked
Pospelove
reviewed
Jul 2, 2024
skymp5-client/src/sync/factions.ts
Outdated
| @@ -0,0 +1,5 @@ | |||
|
|
|||
| export interface Faction { | |||
| formDesc: number; | |||
There was a problem hiding this comment.
formDesc => formId (var name)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.