Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(skymp5-front): update skill description #2274

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

SupAidmi
Copy link
Collaborator

@SupAidmi SupAidmi commented Dec 19, 2024

Important

Update skill descriptions in content.ts to reflect development status and correct weapon specialization details.

  • Skill Descriptions:
    • Updated placeholder text for skills under development in content.ts to indicate they are not fully implemented.
    • Corrected weapon specialization details for 'katana', 'mace', and 'pike' skills.
  • Specific Changes:
    • 'pivovar' skill description now indicates it is under development for initial levels.
    • 'katana' skill now includes 'tan-to' and 'wakizashi' in its description.
    • 'mace' skill description no longer includes 'axes'.
    • 'pike' skill description specifies specialization in one-handed spears and two-handed pikes.

This description was created by Ellipsis for dd8726c. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to dd8726c in 1 minute and 14 seconds

More details
  • Looked at 81 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. skymp5-front/src/features/skillsMenu/content.ts:178
  • Draft comment:
    The levelsDescription still mentions 'топориками', which contradicts the updated description that removes 'топориками'. Please update for consistency.
  • Reason this comment was not posted:
    Comment was on unchanged code.
2. skymp5-front/src/features/skillsMenu/content.ts:246
  • Draft comment:
    The levelsDescription does not reflect the updated description mentioning 'одноручных копьях и двуручных пиках'. Please update for consistency.
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_qmsn3RFngJWLa9SM


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@SupAidmi SupAidmi requested a review from Pospelove December 19, 2024 09:12
@Pospelove Pospelove changed the title Updating skill description feat(skymp5-front): update skill description Dec 19, 2024
@Pospelove Pospelove merged commit c8509fb into main Dec 19, 2024
14 checks passed
@Pospelove Pospelove deleted the SupAidmi-patch-1 branch December 19, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants