MNT: add pre-commit hooks for clang-format and other checks #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade CI clang-format to v16
JJL772
force-pushed
the
enh_pre_commit
branch
2 times, most recently
from
8e804c0 to
e1819f7
Compare
|
This is turning out to be more annoying than I expected |
|
Formatting difference between clang-format v15 (apt) vs v16 on pre-commit, it seems? What we do for formatting is use |
|
Even locally, pre-commit formatted things differently than clang-format-16 for some reason. The version should've been identical between pre-commit's container and my system. I think you're right, running pre-commit in CI for this might help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty straightforward PR, add some pre-commit hooks to avoid annoying
STY: clang-formatcommits.