Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new file_input block kit element soon to be introduced. #1689

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

filmaj
Copy link
Contributor

@filmaj filmaj commented Nov 3, 2023

Summary

In preparation for next week's launch of the new Block Kit File Input element.

@filmaj filmaj added semver:minor enhancement M-T: A feature request for new functionality area:typescript issues that specifically impact using the package from typescript projects pkg:types applies to `@slack/types` labels Nov 3, 2023
@filmaj filmaj requested review from henrymingwu and a team November 3, 2023 16:48
@filmaj filmaj self-assigned this Nov 3, 2023
@filmaj filmaj added this to the [email protected] milestone Nov 3, 2023
Copy link
Contributor

@hello-ashleyintech hello-ashleyintech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@WilliamBergamin WilliamBergamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but should we include the parameter for file extensions?

@henrymingwu
Copy link

henrymingwu commented Nov 8, 2023

FYI let's hold off on this until 11/13 at least? Context: delayed our GA by a couple of days: https://slack-pde.slack.com/archives/C0539UD5E6M/p1699467241515679?thread_ts=1699461506.812299&cid=C0539UD5E6M

@filmaj
Copy link
Contributor Author

filmaj commented Nov 14, 2023

@WilliamBergamin what do you mean by the following?

should we include the parameter for file extensions?

@WilliamBergamin
Copy link
Contributor

WilliamBergamin commented Nov 14, 2023

@filmaj there is a parameter that allows the developer to restrict the file type being sent from the user I think it is allowed_filetypes_group: "ALL", but I don't think we currently support this field in the parameter definition

The JSON looks like this

{
        title: "Enter a file",
        name: "image-123",
        type: Schema.types.array,
        maxItems: 1,
        description: "",
        items: {
          type: Schema.slack.types.file_id,
          allowed_filetypes_group: "ALL"
        },
      }

@henrymingwu was this feature intended for developers

@filmaj
Copy link
Contributor Author

filmaj commented Nov 14, 2023

@WilliamBergamin I believe the code snippet you shared is for OpenForm fields in the automation platform. However, the interface is a bit different for the File Input block element; see the reference doc for it here: https://api.slack.com/reference/block-kit/block-elements#file_input

@WilliamBergamin
Copy link
Contributor

Ohh completely missed filetypes field :shipit:

@filmaj filmaj merged commit 41f771e into main Nov 14, 2023
14 checks passed
@filmaj filmaj deleted the file-upload-element branch November 14, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:typescript issues that specifically impact using the package from typescript projects enhancement M-T: A feature request for new functionality pkg:types applies to `@slack/types` semver:minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants