Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AxiStreamRingBuffer Bug fix and whitespace removal #1142

Merged
merged 3 commits into from
Feb 26, 2024

Conversation

ruck314
Copy link
Contributor

@ruck314 ruck314 commented Feb 26, 2024

@ruck314 ruck314 requested review from jumdz and mmishra9 February 26, 2024 18:54
@ruck314 ruck314 changed the title Kek bpm ring buffer fix AxiStreamRingBuffer Bug fix and whitespace removal Feb 26, 2024
Copy link
Contributor

@jumdz jumdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks ok to me, I don't see any obvious error but I do not have any setup in place to test it. @ruck314, do you want me to give a try or did you already test it ?

@ruck314
Copy link
Contributor Author

ruck314 commented Feb 26, 2024

@jumdz I wrote the simple simulation test bed to confirm that I observe the same behavior that Riku was seeing and verified that it is fixed.

@ruck314 ruck314 merged commit 5320859 into pre-release Feb 26, 2024
3 checks passed
@ruck314 ruck314 deleted the kek-bpm-ring-buffer-fix branch February 26, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants