Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UdpEngineWrapper.vhd & _UdpEngine.py Updates #1144

Merged
merged 4 commits into from
Mar 18, 2024
Merged

Conversation

ruck314
Copy link
Contributor

@ruck314 ruck314 commented Mar 1, 2024

Description

@ruck314 ruck314 marked this pull request as ready for review March 2, 2024 00:24
@ruck314 ruck314 requested a review from bengineerd March 2, 2024 00:24
@bengineerd
Copy link
Contributor

Is it intended that softIp and softMac wrap back externally to localIp and localMac? They don't seem to go anywhere otherwise. But that seems a bit complicated. Could we have a generic that allows the soft registers to override the local inputs?

@ruck314
Copy link
Contributor Author

ruck314 commented Mar 6, 2024

@bengineerd Externally loop backed because the softMac also drives the ETH PHY/MAC module as well (external of UdpEngineWrapper)

   ------------------------------------
   -- IPv4/ARP/UDP/DHCP Ethernet Layers
   ------------------------------------
   U_UDP : entity surf.UdpEngineWrapper
      generic map (
         -- Simulation Generics
         TPD_G          => TPD_G,
         -- UDP Server Generics
         SERVER_EN_G    => true,          -- UDP Server only
         SERVER_SIZE_G  => 1,
         SERVER_PORTS_G => SERVER_PORTS_C,
         -- UDP Client Generics
         CLIENT_EN_G    => false,         -- UDP Server only
         -- General IPv4/ARP/DHCP Generics
         DHCP_G         => false,
         CLK_FREQ_G     => AXIL_CLK_FREQ_G,
         COMM_TIMEOUT_G => 30)            -- Timeout used for ARP and DHCP
      port map (
         -- Local Configurations
         localMac           => localMac,  -- Configured via PCIe
         localIp            => localIp,   -- Configured via PCIe
         softMac            => localMac,  -- externally loopback
         softIp             => localIp,   -- externally loopback

@ruck314 ruck314 merged commit b2bc236 into pre-release Mar 18, 2024
3 checks passed
@ruck314 ruck314 deleted the UdpEngineWrapper branch March 18, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants