Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TPM manufacturer lookup for names with a space (0x20) character #670

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

hslatman
Copy link
Member

@hslatman hslatman commented Jan 8, 2025

This PR fixes lookup for TPM manufacturer names that have space (and other white space) character(s) in their ASCII representation.

When showing the name the original representation is kept for easier reference with the TCG registry of TPM manufacturers. Alternatively we could strip it from that representation too, but I think it's fine to keep it, and to just strip it during lookup.

@hslatman hslatman requested review from a team and maraino January 8, 2025 23:34
@hslatman hslatman enabled auto-merge January 9, 2025 00:21
@hslatman hslatman merged commit ecbfacf into master Jan 9, 2025
14 checks passed
@hslatman hslatman deleted the herman/fix-tpm-manufacturer-ascii-lookup branch January 9, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants