Teambuilder: Fix HPIvs ignoring hypertraining #2317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were two cases where hidden powers IVs would be written to a set that could be hypertrained: 1. Set/team imports 2. When maxing the IVs of a stat (eg. when a physical move is chosen) The first case has been fixed by making `Storage#importTeam` take a `format` paramater to determine whether hypertraining is possible. The `format` is only needed when the import is a set since the format is not written to a set so it needs to be specified. In the second case, its a simple change in `TeamBuilderRoom#changeMove` to adjust maxing a stat to set it to `31` if it can be hypertrained.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two cases where hidden powers IVs would be written to a set that could be hypertrained:
The first case has been fixed by making
Storage#importTeamtake aformatparamater to determine whether hypertraining is possible. Theformatis only needed when the import is a set since the format is not written to a set so it needs to be specified.In the second case, its a simple change in
TeamBuilderRoom#changeMoveto adjust maxing a stat to set it to31if it can be hypertrained.