Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a plugin to play Chess #8068

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Add a plugin to play Chess #8068

wants to merge 12 commits into from

Conversation

mia-pi-git
Copy link
Member

Pain.

@mia-pi-git mia-pi-git force-pushed the chess branch 4 times, most recently from 245ea0a to a766a3a Compare February 23, 2021 19:18
@mia-pi-git
Copy link
Member Author

current look: https://i.imgur.com/nnTBuWN.png

@DaWoblefet DaWoblefet marked this pull request as draft February 23, 2021 20:58
@mia-pi-git mia-pi-git force-pushed the chess branch 5 times, most recently from f2d2f3a to 2a578d2 Compare February 24, 2021 16:45
@Zarel
Copy link
Member

Zarel commented Feb 24, 2021

Looks good, but you can probably implement movement with buttons.

Zarel
Zarel reviewed Feb 24, 2021
View reviewed changes
server/chat-commands/core.ts Outdated Show resolved Hide resolved
Zarel
Zarel reviewed Feb 24, 2021
View reviewed changes
server/chat-plugins/chess.ts Outdated Show resolved Hide resolved
@mia-pi-git
Copy link
Member Author

mia-pi-git commented Feb 24, 2021 •
edited
Loading

Looks good, but you can probably implement movement with buttons.

I did already. See ChessGame#getBoard.

@mia-pi-git mia-pi-git marked this pull request as ready for review February 24, 2021 17:56
@mia-pi-git mia-pi-git force-pushed the chess branch 5 times, most recently from a399b25 to dfd4a7e Compare February 24, 2021 18:23
@Zarel
Copy link
Member

Zarel commented Feb 24, 2021

Ah, the instructions to use a command threw me off. You might want hide those instructions behind a "click to play".

@mia-pi-git
Copy link
Member Author

Ah, the instructions to use a command threw me off. You might want hide those instructions behind a "click to play".

i updated it to say "do either [command] or [click]" in my last push, if that helps.

@mia-pi-git
Copy link
Member Author

Or, wait, no. Misread.

@mia-pi-git mia-pi-git force-pushed the chess branch 11 times, most recently from 5f3de96 to 8e990c3 Compare February 27, 2021 22:22
@mia-pi-git
Copy link
Member Author

@Zarel bump

@Zarel
Copy link
Member

Zarel commented Mar 17, 2021

(Looks like there are still build errors.)

@Zarel
Copy link
Member

Zarel commented Mar 17, 2021

I would review in an incomplete state but I'm massively backlogged.

@mia-pi-git
Copy link
Member Author

I would review in an incomplete state but I'm massively backlogged.

Fixed the check, if that helps.

@monsanto
Copy link
Member

monsanto commented Jan 7, 2023 •
edited
Loading

This looks like fun but I don't have time to review changes to non-essential functionality. If this won't break anything I don't mind if it is merged. I think long-term this type of thing should go in a bot/different repository.

@PartMan7
Copy link
Collaborator

PartMan7 commented Jan 7, 2023

PartBot from the Board Games room says hi~

@PartMan7
Copy link
Collaborator

@mia-pi-git is this planned on being actually added?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyuk-bot pyuk-bot pyuk-bot left review comments

@Zarel Zarel Zarel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mia-pi-git @Zarel @monsanto @PartMan7 @pyuk-bot