Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issues https://github.com/snoe/node-cljfmt/issues/7 #8

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

oneness
Copy link

@oneness oneness commented Aug 20, 2019

No description provided.

@snoe
Copy link
Owner

snoe commented Aug 22, 2019

Thanks @oneness , can you please update the patch to only add the relevant line without the whitespace changes. Also please remove the binary as I'll compile that myself when I release.

@oneness
Copy link
Author

oneness commented Aug 22, 2019

Just pushed as you request. Please merge if ok.

@snoe
Copy link
Owner

snoe commented Aug 23, 2019

@oneness Sorry for my imprecise language, remove the /bin/cljfmt line from gitignore, and in your patch reset to the version of the binary on master. I want the binary to be in the repo, but I can't accept patches to the binary itself.

@oneness
Copy link
Author

oneness commented Aug 26, 2019

@snoe Just pushed the .gitignore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants