-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schema DDL: add support for 'date' format #256
Conversation
@miike has signed the CLA. |
Thanks for this @miike - I was schema'ing Northwind the other day and was wishing for a
My view is that we should pretend |
I absolutely agree - we should support it. Even further, according to v4 - it is up to to validator app to implement custom formats. Which means we're absolutely free to add custom validators with formats like See #170 |
Great, scheduling |
Cherry-picked to #280 . |
This adds support for suggesting a Redshift
DATE
type when specifying"format": "date"
in a JSON schema.It's not entirely clear as to what is the best way to support a date with no time component as date was present in JSON schema v3 but removed in later versions. In v4 the spec mentions that anything with
"format": "date-time"
should meet section 5.6 of RFC3339 but the ABNF for "date-time" suggests that both a full date and a full time are requireddate-time = full-date "T" full-time
this differs from the ISO8601 which allows for partial dates. Thoughts @chuwy @alexanderdean?