More improvements in HTTP client #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pondzix
force-pushed
the
more_http_client_pooling_improvements
branch
2 times, most recently
from
5596a7e to
78250dd
Compare
colmsnowplow
approved these changes
Jan 13, 2025
Continuation of 065a10a: * Use `http.DefaultTransport` It's because transport provided by `net/http` has some sensible defaults. Before that change we would use "empty" `http.Transport` with "empty" defaults. * Set `MaxIdleConnsPerHost` equal to the `MaxIdleConns` In Snowbridge we basically target single host, so it makes sens to set `MaxIdleConnsPerHost` == `MaxIdleConns`. `MaxIdleConns` provided by the `http.DefaultTransport` is 100. Before that change `MaxIdleConnsPerHost` was 2 (`http.DefaultMaxIdleConnsPerHost`). * Drain and close response body in defer function
pondzix
force-pushed
the
more_http_client_pooling_improvements
branch
from
78250dd to
caf3386
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: PDP-1643 PDP-1625 PDP-1624
Continuation of 065a10a:
http.DefaultTransportIt's because transport provided by
net/httphas some sensible defaults. Before that change we would use "empty"http.Transport{}with "empty" defaults.MaxIdleConnsPerHostequal to theMaxIdleConnsIn Snowbridge we basically target single host, so it makes sens to set
MaxIdleConnsPerHost==MaxIdleConns.MaxIdleConnsprovided by thehttp.DefaultTransportis 100. Before that changeMaxIdleConnsPerHostwas 2 (http.DefaultMaxIdleConnsPerHost).