Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CommonEventProperties type argument #1254

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Add CommonEventProperties type argument #1254

merged 1 commit into from
Nov 14, 2023

Conversation

igneel64
Copy link
Contributor

close #1249

@snowplowcla snowplowcla added the cla:yes [Auto generated] Snowplow Contributor License Agreement has been signed. label Oct 17, 2023
@bundlemon
Copy link

bundlemon bot commented Oct 17, 2023 •
edited
Loading

BundleMon

Files added (6)
Status Path Size Limits
✅ libraries/browser-tracker-core/dist/index.mod
ule.js
 +25.32KB 26KB / +10%
✅ trackers/javascript-tracker/dist/sp.js
 +24.22KB 25KB / +10%
✅ trackers/javascript-tracker/dist/sp.lite.js
 +14.86KB 15KB / +10%
✅ trackers/browser-tracker/dist/index.umd.min.j
s
 +14.7KB 15KB / +10%
✅ libraries/tracker-core/dist/index.module.js
 +13.35KB 15KB / +10%
✅ trackers/browser-tracker/dist/index.module.js
 +3.51KB 5KB / +10%

Total files change +95.96KB 0%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history

@igneel64 igneel64 force-pushed the feature/1249-common-event-properties-type-arg branch from e55e715 to 3d4e8c9 Compare October 17, 2023 09:18
matus-tomlein
matus-tomlein approved these changes Oct 21, 2023
View reviewed changes
Copy link
Contributor

@matus-tomlein matus-tomlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@igneel64 igneel64 merged commit 0008f6e into release/3.17.0 Nov 14, 2023
2 checks passed
adatzer pushed a commit that referenced this pull request Nov 14, 2023
@igneel64 @adatzer
Add CommonEventProperties type argument (close #1249)
a7131c3 
#1254
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matus-tomlein matus-tomlein matus-tomlein approved these changes

Assignees
No one assigned
Labels
cla:yes [Auto generated] Snowplow Contributor License Agreement has been signed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igneel64 @matus-tomlein @snowplowcla