-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Host Javascript API docs (close #1255) #1256
Conversation
BundleMonFiles added (6)
Total files change +97.15KB 0% Final result: ✅ View report in BundleMon website ➡️ |
.github/workflows/docs.yml
Outdated
push: | ||
branches: | ||
- issue/1255-host_js_docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will get changed to something like:
on:
workflow_run:
workflows: ["Deploy Tracker"]
types:
- completed
to update once docs are generated in publish.yml
Can you add a search at all? Feels hard to find anything atm |
@rlh1994 I'll need to apply for an API key from algolia, but yeah assuming we get approved it shouldn't be an issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! You might need to rebase on top of the release branch and resolve the remaining conflicts.
14bc54d
to
38c7bfa
Compare
This PR adds hosted api docs to gh-pages for the browser and node trackers. The homepage can be found here:
https://snowplow.github.io/snowplow-javascript-tracker/docs/