Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider status codes <200 (close #1244) #1258

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Consider status codes <200 (close #1244) #1258

merged 1 commit into from
Oct 23, 2023

Conversation

greg-el
Copy link
Contributor

@greg-el greg-el commented Oct 20, 2023

This PR allows status codes under 200 to be considered when passed into shouldRetryForStatusCode.

@snowplowcla snowplowcla added the cla:yes [Auto generated] Snowplow Contributor License Agreement has been signed. label Oct 20, 2023
@bundlemon
Copy link

bundlemon bot commented Oct 20, 2023 •
edited
Loading

BundleMon

Files added (6)
Status Path Size Limits
✅ libraries/browser-tracker-core/dist/index.mod
ule.js
 +25.32KB 26KB / +10%
✅ trackers/javascript-tracker/dist/sp.js
 +24.22KB 25KB / +10%
✅ trackers/javascript-tracker/dist/sp.lite.js
 +14.86KB 15KB / +10%
✅ trackers/browser-tracker/dist/index.umd.min.j
s
 +14.7KB 15KB / +10%
✅ libraries/tracker-core/dist/index.module.js
 +13.35KB 15KB / +10%
✅ trackers/browser-tracker/dist/index.module.js
 +3.51KB 5KB / +10%

Total files change +95.96KB 0%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history

@greg-el greg-el requested a review from matus-tomlein October 20, 2023 16:40
matus-tomlein
matus-tomlein approved these changes Oct 21, 2023
View reviewed changes
Copy link
Contributor

@matus-tomlein matus-tomlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@greg-el greg-el force-pushed the issue/1244-consider-status-codes-under-200 branch from d5b4bc3 to f43467e Compare October 23, 2023 11:02
@greg-el greg-el merged commit c7ec1d7 into release/3.17.0 Oct 23, 2023
2 checks passed
@greg-el greg-el deleted the issue/1244-consider-status-codes-under-200 branch August 9, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matus-tomlein matus-tomlein matus-tomlein approved these changes

Assignees
No one assigned
Labels
cla:yes [Auto generated] Snowplow Contributor License Agreement has been signed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@greg-el @matus-tomlein @snowplowcla