-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OTB Button Click Tracking (close #1267) #1269
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowplowcla
added
the
cla:yes
[Auto generated] Snowplow Contributor License Agreement has been signed.
label
Nov 24, 2023
BundleMonFiles added (6)
Total files change +97.15KB 0% Final result: ✅ View report in BundleMon website ➡️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice implementation, great work! 👍
matus-tomlein
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
greg-el
force-pushed
the
issue/1267-otb-button-click-tracking
branch
from
November 28, 2023 13:43
24eb26f
to
fe51795
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a plugin for automatic button click tracking, similar to the existing link click tracking.
It provides a single method,
enableButtonClickTracking
. Which accepts a couple of options:enableButtonClickTracking.filter
This allows the user to provide either an allowlist, denylist, or a custom callback, that will only track a click if the element that has been clicked on passes the filter, for example of a function filter that will accept the following button:
enableButtonClickTracking.context
Allows attaching a dynamic entity to the button click events.
note: The integration tests won't pass on CI, as the button click schema isn't on Iglu Central yet (see snowplow/iglu-central@master...release/r150)