Fix multiple link click events tracked for a single tracker in case multiple trackers are initialized on the page (close #1384) #1385
+45
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ultiple trackers are initialized on the page (close #1384)
BundleMonFiles added (6)
Total files change +105.54KB 0% Final result: ✅ View report in BundleMon website ➡️ |
jethron
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1384
Since the v4 release, in case multiple trackers were initialized on the same page, link click tracking tracked multiple events on each tracker for each link click.
For instance, in case 3 trackers were initialized and link click tracking was enabled, each link click would result in 3 events on each tracker.
This PR fixes the problem by qualifying which tracker should be used in the
trackLinkClickfunction call from the click handler.