Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with Python 3.13 #365

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

edgarrmondragon
Copy link
Contributor

No description provided.

@snowplowcla snowplowcla added the cla:yes [Auto generated] Snowplow Contributor License Agreement has been signed. label Aug 22, 2024
@edgarrmondragon edgarrmondragon marked this pull request as ready for review August 22, 2024 16:31
@edgarrmondragon edgarrmondragon marked this pull request as draft August 22, 2024 16:31
@coveralls
Copy link

coveralls commented Aug 22, 2024

Coverage Status

coverage: 96.619%. remained the same
when pulling 43d4f6b on edgarrmondragon:py313
into 2c381e0 on snowplow:master.

@matus-tomlein matus-tomlein requested a review from greg-el August 22, 2024 16:52
@edgarrmondragon edgarrmondragon marked this pull request as ready for review August 22, 2024 19:48
@miike
Copy link
Contributor

miike commented Aug 22, 2024

My feeling is that we probably hold off on this until early October so we're running tests against 3.13 stable rather than one of the 3.13 release candidates.

@edgarrmondragon
Copy link
Contributor Author

My feeling is that we probably hold off on this until early October so we're running tests against 3.13 stable rather than one of the 3.13 release candidates.

Happy to keep this open and come back around October 1st to make the changes for the final release.

@miike
Copy link
Contributor

miike commented Aug 23, 2024

Thanks @edgarrmondragon, much appreciated. I'll set up a reminder as well.

@miike
Copy link
Contributor

miike commented Sep 30, 2024

It's October 1st but the final release of 3.13 has been pushed out to the 7th, will check back in then.

@edgarrmondragon
Copy link
Contributor Author

edgarrmondragon commented Oct 8, 2024

I'm opening this for review, although this hasn't been released yet:

- pyenv/pyenv#3081

Update: pyenv 2.4.15 is out now

@edgarrmondragon edgarrmondragon marked this pull request as ready for review October 8, 2024 16:31
@edgarrmondragon
Copy link
Contributor Author

ping @miike 🙏

@miike
Copy link
Contributor

miike commented Nov 15, 2024

Thanks @edgarrmondragon . @greg-el @matus-tomlein Do you mind giving this a review please?

Copy link
Contributor

@matus-tomlein matus-tomlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @edgarrmondragon and sorry for the delay! We will take it from here.

@matus-tomlein matus-tomlein changed the base branch from master to release/1.0.4 November 19, 2024 11:10
@matus-tomlein matus-tomlein merged commit 74c9377 into snowplow:release/1.0.4 Nov 19, 2024
10 checks passed
@matus-tomlein matus-tomlein mentioned this pull request Nov 19, 2024
@edgarrmondragon edgarrmondragon deleted the py313 branch November 19, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes [Auto generated] Snowplow Contributor License Agreement has been signed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants