Loader should not call the "list" Iglu endpoint for Snowflake/Databricks tables #1350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cks tables When loading to Redshift, the loader needs to call the "list" Iglu api endpoint in order to discover all minor versions of a schema. It uses the list to merge the schemas. But for Snowflake/Databricks tables the loader does not need to merge schemas, so there is no need to call the "list" endpoint. In RDB Loader version 6.0.0 we accidentally changed the loader so it calls the "list" endpoint regardless of the table type. This is a problem for Snowflake/Databricks loads because: - it is inefficient to call a api endpoint when we don't need the result - some old Iglu repos do not support the list endpoint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ref: PDP-1274
When loading to Redshift, the loader needs to call the "list" Iglu api endpoint in order to discover all minor versions of a schema. It uses the list to merge the schemas.
But for Snowflake/Databricks tables the loader does not need to merge schemas, so there is no need to call the "list" endpoint.
In RDB Loader version 6.0.0 we accidentally changed the loader so it calls the "list" endpoint regardless of the table type. This is a problem for Snowflake/Databricks loads because: