Skip to content

Commit

Permalink
Remove unused warmup config section
Browse files Browse the repository at this point in the history
We no longer implement specific warmup logic.
  • Loading branch information
AlexBenny authored and peel committed Jan 8, 2024
1 parent cc8a825 commit e85d055
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 64 deletions.
12 changes: 0 additions & 12 deletions examples/config.kafka.extended.hocon
Original file line number Diff line number Diff line change
Expand Up @@ -286,16 +286,4 @@ collector {

# The server's deadline for closing connections during graceful shutdown
terminationDeadline = 10 seconds

experimental {
# Enable an experimental feature to send some "warm-up" requests to the collector's own /health endpoint during startup.
# We have found from experiment this can cut down the number of 502s returned from a load balancer in front of the collector in Kubernetes deployments.
# More details in https://github.com/snowplow/stream-collector/issues/249
warmup {
enable = false
numRequests = 2000
maxConnections = 2000
maxCycles = 3
}
}
}
12 changes: 0 additions & 12 deletions examples/config.kinesis.extended.hocon
Original file line number Diff line number Diff line change
Expand Up @@ -370,16 +370,4 @@ collector {

# The server's deadline for closing connections during graceful shutdown
terminationDeadline = 10 seconds

experimental {
# Enable an experimental feature to send some "warm-up" requests to the collector's own /health endpoint during startup.
# We have found from experiment this can cut down the number of 502s returned from a load balancer in front of the collector in Kubernetes deployments.
# More details in https://github.com/snowplow/stream-collector/issues/249
warmup {
enable = false
numRequests = 2000
maxConnections = 2000
maxCycles = 3
}
}
}
12 changes: 0 additions & 12 deletions examples/config.pubsub.extended.hocon
Original file line number Diff line number Diff line change
Expand Up @@ -302,16 +302,4 @@ collector {

# The server's deadline for closing connections during graceful shutdown
terminationDeadline = 10 seconds

experimental {
# Enable an experimental feature to send some "warm-up" requests to the collector's own /health endpoint during startup.
# We have found from experiment this can cut down the number of 502s returned from a load balancer in front of the collector in Kubernetes deployments.
# More details in https://github.com/snowplow/stream-collector/issues/249
warmup {
enable = false
numRequests = 2000
maxConnections = 2000
maxCycles = 3
}
}
}
16 changes: 0 additions & 16 deletions examples/config.sqs.extended.hocon
Original file line number Diff line number Diff line change
Expand Up @@ -113,10 +113,6 @@ collector {
name = "n3pc"
# Network user id to fallback to when third-party cookies are blocked.
fallbackNetworkUserId = "00000000-0000-4000-A000-000000000000"
# Optionally, specify the name of the header containing the originating protocol for use in the
# bounce redirect location. Use this if behind a load balancer that performs SSL termination.
# The value of this header must be http or https. Example, if behind an AWS Classic ELB.
#forwardedProtocolHeader = "X-Forwarded-Proto"
}

# When enabled, redirect prefix `r/` will be enabled and its query parameters resolved.
Expand Down Expand Up @@ -297,16 +293,4 @@ collector {

# The server's deadline for closing connections during graceful shutdown
terminationDeadline = 10 seconds

experimental {
# Enable an experimental feature to send some "warm-up" requests to the collector's own /health endpoint during startup.
# We have found from experiment this can cut down the number of 502s returned from a load balancer in front of the collector in Kubernetes deployments.
# More details in https://github.com/snowplow/stream-collector/issues/249
warmup {
enable = false
numRequests = 2000
maxConnections = 2000
maxCycles = 3
}
}
}
12 changes: 0 additions & 12 deletions examples/config.stdout.extended.hocon
Original file line number Diff line number Diff line change
Expand Up @@ -241,16 +241,4 @@ collector {

# The server's deadline for closing connections during graceful shutdown
terminationDeadline = 10 seconds

experimental {
# Enable an experimental feature to send some "warm-up" requests to the collector's own /health endpoint during startup.
# We have found from experiment this can cut down the number of 502s returned from a load balancer in front of the collector in Kubernetes deployments.
# More details in https://github.com/snowplow/stream-collector/issues/249
warmup {
enable = false
numRequests = 2000
maxConnections = 2000
maxCycles = 3
}
}
}

0 comments on commit e85d055

Please sign in to comment.