Use Fiber.schedule in Streamable.
#68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm unhappy that this was the only way to effectively implement this functionality, but I could not see any easy way to implement asynchronous flow control which is what is needed if invoking
#eachon a Streamable. The alternative is to simply fail. I tried implementing a bi-directional queue for handling input and output but it was extremely difficult to make it make sense in the context of both client and server behaviour, across HTTP/1 and HTTP/2+.Therefore, using
Fiber.schedulemakes sense. However, I'm unhappy because it specifically introduces asynchronicity into a library which is supposed to be strictly sequential. It turns out implementing it sequentially is not worth the complexity.Types of Changes
Contribution