Include context safety #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioquatix
added a commit
that referenced
this pull request
Jul 22, 2024
* Add before/after/around helpers. * Make it possible to include/prepend shared modules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some practical usage, I found the design of the before, after and around hooks to be a little counter-intuitive.
def beforein a shared context can clobber existing before hooks.beforeandafterhooks are all run from bottom to top, and thenaroundhooks. This leads to odd interleaving of hooks, in other words, anaroundhook is not equivalent tobeforeandafterhooks.We introduce a better model for before and after hooks, and a better model for including shared contexts.