[FE 박준혁 / 윤동현] - 옵션 선택 페이지 360도 회전 구현 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feature : change backend data structure / frontend apply animation of preview * feature : Apply Custom Car Option Section
crongro
approved these changes
Jan 24, 2025
| return; | ||
| } | ||
|
|
||
| const api = new API(); |
There was a problem hiding this comment.
API클래스(?)가 생성자가 없다면 클래스 말고 객체리터럴로 만들어서 활용해보세요.
| colors, | ||
| options, | ||
| preview | ||
| }: { colors: Tcolors, options: Toptions, preview: string } = await api.get('/api/car/models/options', { |
There was a problem hiding this comment.
{ colors: Tcolors, options: Toptions, preview: string }
이건 타입이나 인터페이스 미리 만들어서 사용~
그러면 여기 코드가 간편해질듯.
get은 만든것이면 generic으로 만드는것도 방법.
async function get<T>(url: string): Promise<T> {
그리고 호출할때는 이런식으로
await api.get<CarModelOptions>('/car/models/options');
| options: options | ||
| }) | ||
| setPreview(preview); | ||
| setLoading(true); |
There was a problem hiding this comment.
loading처리가 좀 번잡해지죠.
이를때 useFetch 훅같은거 만들어서 사용하곤 합니다.
아니면 react-query를 쓰면 이부분 지원도 되기도 할거 같고요.
|
이거 충돌났따 ~ @jpark0506 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
주요 작업
학습 키워드
고민과 해결과정
tailwind css 사용할 때 after나 before을 사용하면 코드가 많이 난잡해진다는 것을 느꼈다.